Query: About process

Query: About process

[Abhijit Halder]

Hi,

I am pretty new in this community. Just curious to know whether I will
get any notification if my patch get accepted or rejected.


Thanks,
Abhijit Halder

Re: Query: About process

[Phil Muldoon]

Abhijit Halder <abhijit.k.halder@gmail.com> writes:

> Hi,
>
> I am pretty new in this community. Just curious to know whether I will
> get any notification if my patch get accepted or rejected.

Your patch will get reviewed (by anybody, but normally by a
maintainer).  They may require changes to the patch.   

Only a maintainer can grant you approval to commit your patch.  The
CONTRIBUTE file in the gdb/ source directory gives a good overview.

Sometimes, patches can be missed.  I generally "ping" patches after a
week if no review has been forthcoming.  Sometimes the maintainer
work-load is very high, so some things get missed/forgotten.  It is
perfectly acceptable to "ping" a patch after a reasonable time, and you
will not be breaking any etiquette by doing so.

Finally, questions like this generally go to gdb@sourceware.org, and
patch discussion about actual patches to gdb-patches@sourceware.org.
These rules are very loosely applied, so you have done nothing wrong.  I
just thought this would be a good time to point out the other list!

Cheers

Phil

Re: Query: About process

[Abhijit Halder]

On Mon, Aug 1, 2011 at 3:35 PM, Phil Muldoon <pmuldoon@redhat.com> wrote:
> Abhijit Halder <abhijit.k.halder@gmail.com> writes:
>
>> Hi,
>>
>> I am pretty new in this community. Just curious to know whether I will
>> get any notification if my patch get accepted or rejected.
>
> Your patch will get reviewed (by anybody, but normally by a
> maintainer).  They may require changes to the patch.
>
> Only a maintainer can grant you approval to commit your patch.  The
> CONTRIBUTE file in the gdb/ source directory gives a good overview.
>
> Sometimes, patches can be missed.  I generally "ping" patches after a
> week if no review has been forthcoming.  Sometimes the maintainer
> work-load is very high, so some things get missed/forgotten.  It is
> perfectly acceptable to "ping" a patch after a reasonable time, and you
> will not be breaking any etiquette by doing so.
>
> Finally, questions like this generally go to gdb@sourceware.org, and
> patch discussion about actual patches to gdb-patches@sourceware.org.
> These rules are very loosely applied, so you have done nothing wrong.  I
> just thought this would be a good time to point out the other list!
>
> Cheers
>
> Phil
>

Thanks for your response.

Regards,
Abhijit Halder

Re: Query: About process

[Sergio Durigan Junior]

Abhijit Halder <abhijit.k.halder@gmail.com> writes:

> I am pretty new in this community. Just curious to know whether I will
> get any notification if my patch get accepted or rejected.

I reviewed your patch, though I am not a maintainter.  Most of the
issues that I found were simple coding standards violations; you
shouldn't take long to fix them.

As Phil said, you won't be able to commit your patch until a maintainer
reviews it.  Meanwhile, I suggest you take a look at the paperwork that
needs to be done in order to be able to gain commit access to the
repository.  If you have any question about it, you can freely ask on
the gdb mailing list (gdb@sourceware.org), or on the IRC channel (we
have a channel at the Freenode network, called #gdb).

Regards,

Sergio.

Re: Query: About process

[Abhijit Halder]

On Tue, Aug 2, 2011 at 9:30 AM, Sergio Durigan Junior
<sergiodj@redhat.com> wrote:
> Abhijit Halder <abhijit.k.halder@gmail.com> writes:
>
>> I am pretty new in this community. Just curious to know whether I will
>> get any notification if my patch get accepted or rejected.
>
> I reviewed your patch, though I am not a maintainter.  Most of the
> issues that I found were simple coding standards violations; you
> shouldn't take long to fix them.

Thanks for the review. I will make the corrections and re-submit the
patch very soon.

>
> As Phil said, you won't be able to commit your patch until a maintainer
> reviews it.  Meanwhile, I suggest you take a look at the paperwork that
> needs to be done in order to be able to gain commit access to the
> repository.  If you have any question about it, you can freely ask on
> the gdb mailing list (gdb@sourceware.org), or on the IRC channel (we
> have a channel at the Freenode network, called #gdb).
>
> Regards,
>
> Sergio.
>