Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Jonas Maebe <jonas.maebe@elis.ugent.be>
Cc: gdb-patches@sourceware.org
Subject: Re: Borland fastcall support (i386)
Date: Mon, 06 Apr 2009 02:15:00 -0000	[thread overview]
Message-ID: <m3d4bq5y3k.fsf@fleche.redhat.com> (raw)
In-Reply-To: <390385D8-5B6E-4844-8940-4002C012140F@elis.ugent.be> (Jonas Maebe's message of "Sun\, 5 Apr 2009 23\:28\:57 +0200")

>>>>> "Jonas" == Jonas Maebe <jonas.maebe@elis.ugent.be> writes:

Tom> I recently noticed that the src and gcc versions of this file have
Tom> diverged.  Oops.  It would be good to have just a single copy; most of
Tom> the work to be done here is in the gcc repository.

Jonas> I've submitted the patch to gcc-patches.

Actually, I was hoping for something more like a merge of the two
copies of dwarf2.h.  Don't feel obligated to do this, though; the
problem predates your patch.

Jonas> Is there a problem with moving the calling_convention field out
Jonas> of the type_specific union, and if not, is there anything I
Jonas> should pay particular attention to? (other than adjusting a
Jonas> couple of macros)

ISTR that the type-related structures are (supposedly) space
sensitive.  But, according to pahole, there are some free bits in
struct main_type.  So, I would suggest packing the field in there.
Aside from that I don't know of any reason it might be a problem.

Tom


  reply	other threads:[~2009-04-06  2:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-03 13:39 Jonas Maebe
2009-04-03 14:55 ` Tom Tromey
2009-04-05 21:29   ` Jonas Maebe
2009-04-06  2:15     ` Tom Tromey [this message]
2009-04-06  2:54     ` Daniel Jacobowitz
2009-04-06  6:20       ` Jonas Maebe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3d4bq5y3k.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jonas.maebe@elis.ugent.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox