From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23714 invoked by alias); 6 Apr 2009 02:15:04 -0000 Received: (qmail 23676 invoked by uid 22791); 6 Apr 2009 02:15:02 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Apr 2009 02:14:55 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n362CpxD010346; Sun, 5 Apr 2009 22:12:51 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n362CqgS015547; Sun, 5 Apr 2009 22:12:52 -0400 Received: from opsy.redhat.com (vpn-12-132.rdu.redhat.com [10.11.12.132]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n362CoNu003388; Sun, 5 Apr 2009 22:12:50 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 439DD378264; Sun, 5 Apr 2009 20:12:48 -0600 (MDT) To: Jonas Maebe Cc: gdb-patches@sourceware.org Subject: Re: Borland fastcall support (i386) References: <390385D8-5B6E-4844-8940-4002C012140F@elis.ugent.be> From: Tom Tromey Reply-To: tromey@redhat.com Date: Mon, 06 Apr 2009 02:15:00 -0000 In-Reply-To: <390385D8-5B6E-4844-8940-4002C012140F@elis.ugent.be> (Jonas Maebe's message of "Sun\, 5 Apr 2009 23\:28\:57 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00099.txt.bz2 >>>>> "Jonas" == Jonas Maebe writes: Tom> I recently noticed that the src and gcc versions of this file have Tom> diverged. Oops. It would be good to have just a single copy; most of Tom> the work to be done here is in the gcc repository. Jonas> I've submitted the patch to gcc-patches. Actually, I was hoping for something more like a merge of the two copies of dwarf2.h. Don't feel obligated to do this, though; the problem predates your patch. Jonas> Is there a problem with moving the calling_convention field out Jonas> of the type_specific union, and if not, is there anything I Jonas> should pay particular attention to? (other than adjusting a Jonas> couple of macros) ISTR that the type-related structures are (supposedly) space sensitive. But, according to pahole, there are some free bits in struct main_type. So, I would suggest packing the field in there. Aside from that I don't know of any reason it might be a problem. Tom