From: Tom Tromey <tromey@redhat.com>
To: Tristan Gingold <gingold@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Pass all symfile flags to sym_read.
Date: Fri, 04 Dec 2009 17:00:00 -0000 [thread overview]
Message-ID: <m3d42ufzdk.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20091204124327.GA5714@ulanbator.act-europe.fr> (Tristan Gingold's message of "Fri, 4 Dec 2009 13:43:27 +0100")
>>>>> "Tristan" == Tristan Gingold <gingold@adacore.com> writes:
Tristan> 2009-12-02 Tristan Gingold <gingold@adacore.com>
Tristan> * symfile.h (struct sym_fns): Adjust comment on sym_read.
Tristan> * symfile.c (syms_from_objfile): Pass all symfile flags to sym_read.
Tristan> * dbxread.c (dbx_symfile_read): Rename mainline to symfile_flags,
Tristan> adjust header comment.
Tristan> * elfread.c (elf_symfile_read): Ditto.
Tristan> * somread.c (som_symfile_read): Ditto.
Tristan> * xcoffread.c (xcoff_initial_scan): Ditto.
Tristan> * coffread.c (coff_symfile_read): Rename mainline to symfile_flags.
Tristan> * machoread.c (macho_symfile_read): Ditto.
Tristan> * mipsread.c (mipscoff_symfile_read): Ditto.
This is ok with one little nit fixed...
Tristan> diff --git a/gdb/symfile.h b/gdb/symfile.h
[...]
Tristan> + file we are reading. SYMFILE_FLAGS are the flags passed to
Tristan> + symbol_fil_add & co. */
... typo in "symbol_file_add".
Tom
next prev parent reply other threads:[~2009-12-04 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 12:43 Tristan Gingold
2009-12-04 17:00 ` Tom Tromey [this message]
2009-12-07 9:54 ` Tristan Gingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d42ufzdk.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=gingold@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox