From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27640 invoked by alias); 4 Dec 2009 17:00:54 -0000 Received: (qmail 27629 invoked by uid 22791); 4 Dec 2009 17:00:53 -0000 X-SWARE-Spam-Status: No, hits=0.3 required=5.0 tests=AWL,BAYES_00,KAM_STOCKTIP,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Dec 2009 17:00:48 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nB4H0Ppa011596 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 4 Dec 2009 12:00:25 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nB4H0OtX009782; Fri, 4 Dec 2009 12:00:24 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nB4H0NCB014441; Fri, 4 Dec 2009 12:00:23 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 3F9D6378183; Fri, 4 Dec 2009 10:00:23 -0700 (MST) From: Tom Tromey To: Tristan Gingold Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Pass all symfile flags to sym_read. References: <20091204124327.GA5714@ulanbator.act-europe.fr> Reply-To: tromey@redhat.com Date: Fri, 04 Dec 2009 17:00:00 -0000 In-Reply-To: <20091204124327.GA5714@ulanbator.act-europe.fr> (Tristan Gingold's message of "Fri, 4 Dec 2009 13:43:27 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00055.txt.bz2 >>>>> "Tristan" == Tristan Gingold writes: Tristan> 2009-12-02 Tristan Gingold Tristan> * symfile.h (struct sym_fns): Adjust comment on sym_read. Tristan> * symfile.c (syms_from_objfile): Pass all symfile flags to sym_read. Tristan> * dbxread.c (dbx_symfile_read): Rename mainline to symfile_flags, Tristan> adjust header comment. Tristan> * elfread.c (elf_symfile_read): Ditto. Tristan> * somread.c (som_symfile_read): Ditto. Tristan> * xcoffread.c (xcoff_initial_scan): Ditto. Tristan> * coffread.c (coff_symfile_read): Rename mainline to symfile_flags. Tristan> * machoread.c (macho_symfile_read): Ditto. Tristan> * mipsread.c (mipscoff_symfile_read): Ditto. This is ok with one little nit fixed... Tristan> diff --git a/gdb/symfile.h b/gdb/symfile.h [...] Tristan> + file we are reading. SYMFILE_FLAGS are the flags passed to Tristan> + symbol_fil_add & co. */ ... typo in "symbol_file_add". Tom