From: Tom Tromey <tromey@redhat.com>
To: Gaius Mulley <gaius@glam.ac.uk>
Cc: gdb-patches@sourceware.org, drow@false.org
Subject: Re: recursive bug in dwarf2read.c
Date: Fri, 11 Dec 2009 19:29:00 -0000 [thread overview]
Message-ID: <m3d42lz4w0.fsf@fleche.redhat.com> (raw)
In-Reply-To: <87pr6mliuh.fsf@j228-gm.comp.glam.ac.uk> (Gaius Mulley's message of "Thu, 10 Dec 2009 19:39:02 +0000")
>>>>> "Gaius" == Gaius Mulley <gaius@glam.ac.uk> writes:
Gaius> 2009-12-10 Gaius Mulley <gaius@glam.ac.uk>
Gaius> * dwarf2read.c (read_subroutine_type): Add the subroutine
Gaius> type to the die immediately to allow a parameter type to be
Gaius> the same subroutine type.
This seems almost ok to me.
With this change, read_subroutine_type calls set_die_type twice.
I think it would be preferable to eliminate the second call.
Tom
next prev parent reply other threads:[~2009-12-11 19:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <878wdcto0t.fsf@j228-gm.comp.glam.ac.uk>
[not found] ` <20091209185157.GA29691@caradoc.them.org>
2009-12-10 19:39 ` Gaius Mulley
2009-12-11 19:29 ` Tom Tromey [this message]
2009-12-11 20:56 ` Gaius Mulley
2009-12-11 21:06 ` Tom Tromey
2009-12-16 15:14 ` Gaius Mulley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d42lz4w0.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=drow@false.org \
--cc=gaius@glam.ac.uk \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox