From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-68870-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24357 invoked by alias); 11 Dec 2009 19:29:18 -0000
Received: (qmail 24345 invoked by uid 22791); 11 Dec 2009 19:29:17 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Dec 2009 19:29:11 +0000
Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nBBJT6fT001372 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); 	Fri, 11 Dec 2009 14:29:07 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nBBJT5qI017367; 	Fri, 11 Dec 2009 14:29:05 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nBBJT3OA009580; 	Fri, 11 Dec 2009 14:29:04 -0500
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 852C43782A3; Fri, 11 Dec 2009 12:29:03 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: Gaius Mulley <gaius@glam.ac.uk>
Cc: gdb-patches@sourceware.org, drow@false.org
Subject: Re: recursive bug in dwarf2read.c
References: <878wdcto0t.fsf@j228-gm.comp.glam.ac.uk> 	<20091209185157.GA29691@caradoc.them.org> 	<87pr6mliuh.fsf@j228-gm.comp.glam.ac.uk>
Reply-To: tromey@redhat.com
Date: Fri, 11 Dec 2009 19:29:00 -0000
In-Reply-To: <87pr6mliuh.fsf@j228-gm.comp.glam.ac.uk> (Gaius Mulley's message 	of "Thu, 10 Dec 2009 19:39:02 +0000")
Message-ID: <m3d42lz4w0.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-12/txt/msg00168.txt.bz2

>>>>> "Gaius" == Gaius Mulley <gaius@glam.ac.uk> writes:

Gaius> 2009-12-10  Gaius Mulley  <gaius@glam.ac.uk>
Gaius> 	* dwarf2read.c (read_subroutine_type): Add the subroutine
Gaius> 	  type to the die immediately to allow a parameter type to be
Gaius> 	  the same subroutine type.

This seems almost ok to me.

With this change, read_subroutine_type calls set_die_type twice.
I think it would be preferable to eliminate the second call.

Tom