From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Cc: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Subject: Re: [PING] [RFC/Windows] Remember last tlb type for re-use in windows_get_tlb_type
Date: Fri, 30 Apr 2010 16:17:00 -0000 [thread overview]
Message-ID: <m3d3xg29ve.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100430153441.GB11512@ednor.casa.cgf.cx> (Christopher Faylor's message of "Fri, 30 Apr 2010 11:34:41 -0400")
>>>>> "cgf" == Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org> writes:
cgf> Attaching them to gdbarch would make them permanent for the life of the
cgf> debugging session right? That seems better but I agree that, in practice,
cgf> this is probably just as good.
Yeah, but it would fix a leak that is latent even with Pierre's latest
patch: if you use the TLB, switch arches, use it again, then switch
back, and use it a third time, then that third time will recreate the
types. If the types were attached to the gdbarch, then the third use
would reuse the types created the first time through.
My guess is that this sort of scenario is rare.
Tom
prev parent reply other threads:[~2010-04-30 16:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 8:59 Pierre Muller
2010-04-29 22:24 ` [PING] " Pierre Muller
2010-04-30 14:53 ` Christopher Faylor
2010-04-30 15:06 ` Pierre Muller
[not found] ` <2540.9180707813$1272639973@news.gmane.org>
2010-04-30 15:22 ` Tom Tromey
2010-04-30 15:34 ` Christopher Faylor
2010-04-30 15:42 ` Pierre Muller
2010-04-30 16:17 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d3xg29ve.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox