From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19604 invoked by alias); 30 Apr 2010 16:17:23 -0000 Received: (qmail 19591 invoked by uid 22791); 30 Apr 2010 16:17:21 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_CG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Apr 2010 16:17:17 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3UGHC3g027568 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 30 Apr 2010 12:17:12 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3UGHA0P007926; Fri, 30 Apr 2010 12:17:11 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o3UGHA0L013998; Fri, 30 Apr 2010 12:17:10 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id BD495378746; Fri, 30 Apr 2010 10:17:09 -0600 (MDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Pierre Muller Subject: Re: [PING] [RFC/Windows] Remember last tlb type for re-use in windows_get_tlb_type References: <000f01cadf9e$a4fd4910$eef7db30$@muller@ics-cnrs.unistra.fr> <002401cae7ea$ba4b48e0$2ee1daa0$@muller@ics-cnrs.unistra.fr> <20100430145338.GA11512@ednor.casa.cgf.cx> <2540.9180707813$1272639973@news.gmane.org> <20100430153441.GB11512@ednor.casa.cgf.cx> Reply-To: Tom Tromey Date: Fri, 30 Apr 2010 16:17:00 -0000 In-Reply-To: <20100430153441.GB11512@ednor.casa.cgf.cx> (Christopher Faylor's message of "Fri, 30 Apr 2010 11:34:41 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00996.txt.bz2 >>>>> "cgf" == Christopher Faylor writes: cgf> Attaching them to gdbarch would make them permanent for the life of the cgf> debugging session right? That seems better but I agree that, in practice, cgf> this is probably just as good. Yeah, but it would fix a leak that is latent even with Pierre's latest patch: if you use the TLB, switch arches, use it again, then switch back, and use it a third time, then that third time will recreate the types. If the types were attached to the gdbarch, then the third use would reuse the types created the first time through. My guess is that this sort of scenario is rare. Tom