Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@codesourcery.com>
To: Michael Snyder <msnyder@specifix.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: tracepoints: extend range of ax_trace_quick function
Date: Mon, 29 Oct 2007 17:48:00 -0000	[thread overview]
Message-ID: <m3bqahnbno.fsf@codesourcery.com> (raw)
In-Reply-To: <1193472363.16917.100.camel@localhost.localdomain> (Michael Snyder's message of "Sat, 27 Oct 2007 01:06:03 -0700")


Michael Snyder <msnyder at specifix.com> writes:
> On Fri, 2007-10-26 at 15:59 -0700, Jim Blandy wrote:
>> In order to get Linux kernel tracepoints working, I needed to make a
>> number of fixes in GDB.  This is one such patch; the code which uses
>> the function's new range comes a bit later.
>> 
>> Okay to commit?
>
> If I understand correctly, a trace_quick was formerly of size up to 
> 8 bits.  You've added a trace16 for objects up to 16 bits, and this
> just allows trace_quick to handle those objects by forwarding them
> to trace16.
>
> In which case, it looks fine.

I'll commit; thanks!

trace16 has been in there for some time; agentexpr.texi says:

@item Why does @code{trace16} exist?
That opcode was added by the customer that contracted Cygnus for the
data tracing work.  I personally think it is unnecessary; objects that
large will be quite rare, so it is okay to use @code{dup const16
@var{size} trace} in those cases.

Whatever we decide to do with @code{trace16}, we should at least leave
opcode 0x30 reserved, to remain compatible with the customer who added
it.


      reply	other threads:[~2007-10-29 16:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <m34pgdcwj2.fsf@codesourcery.com>
2007-10-27  8:12 ` Michael Snyder
2007-10-29 17:48   ` Jim Blandy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3bqahnbno.fsf@codesourcery.com \
    --to=jimb@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@specifix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox