From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20970 invoked by alias); 29 Oct 2007 16:11:48 -0000 Received: (qmail 20961 invoked by uid 22791); 29 Oct 2007 16:11:46 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 29 Oct 2007 16:11:42 +0000 Received: (qmail 18669 invoked from network); 29 Oct 2007 16:11:40 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 29 Oct 2007 16:11:40 -0000 To: Michael Snyder Cc: gdb-patches@sourceware.org Subject: Re: RFC: tracepoints: extend range of ax_trace_quick function References: <1193472363.16917.100.camel@localhost.localdomain> From: Jim Blandy Date: Mon, 29 Oct 2007 17:48:00 -0000 In-Reply-To: <1193472363.16917.100.camel@localhost.localdomain> (Michael Snyder's message of "Sat, 27 Oct 2007 01:06:03 -0700") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00756.txt.bz2 Michael Snyder writes: > On Fri, 2007-10-26 at 15:59 -0700, Jim Blandy wrote: >> In order to get Linux kernel tracepoints working, I needed to make a >> number of fixes in GDB. This is one such patch; the code which uses >> the function's new range comes a bit later. >> >> Okay to commit? > > If I understand correctly, a trace_quick was formerly of size up to > 8 bits. You've added a trace16 for objects up to 16 bits, and this > just allows trace_quick to handle those objects by forwarding them > to trace16. > > In which case, it looks fine. I'll commit; thanks! trace16 has been in there for some time; agentexpr.texi says: @item Why does @code{trace16} exist? That opcode was added by the customer that contracted Cygnus for the data tracing work. I personally think it is unnecessary; objects that large will be quite rare, so it is okay to use @code{dup const16 @var{size} trace} in those cases. Whatever we decide to do with @code{trace16}, we should at least leave opcode 0x30 reserved, to remain compatible with the customer who added it.