From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <muller@ics.u-strasbg.fr>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [RFA] Build failure fix: Python troubles on non-python targets...
Date: Thu, 28 May 2009 15:38:00 -0000 [thread overview]
Message-ID: <m3bppdtf9p.fsf@fleche.redhat.com> (raw)
In-Reply-To: <001001c9df7b$8f2a3810$ad7ea830$@u-strasbg.fr> (Pierre Muller's message of "Thu\, 28 May 2009 12\:03\:33 +0200")
>>>>> "Pierre" == Pierre Muller <muller@ics.u-strasbg.fr> writes:
Pierre> On DJGPP,
Pierre> I now get this failure:
[...]
Sorry about that.
Pierre> The following two changes fixes compilation for me:
Pierre> Is this patch OK?
Nearly...
Pierre> +
Pierre> +#ifdef HAVE_PYTHON
Pierre> +
Pierre> #include "python.h"
Pierre> #include "python-internal.h"
This should unconditionally include python.h. So, the conditional
needs to be moved down a few lines. It is ok to include python.h even
if Python is not available; and in this case it is desirable so that
the declarations are picked up (and thus checked against the
definitions).
Ok with that change. Thanks.
Tom
next prev parent reply other threads:[~2009-05-28 15:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 10:03 Pierre Muller
2009-05-28 14:56 ` Paul Pluzhnikov
2009-05-28 15:38 ` Tom Tromey [this message]
2009-05-28 16:22 ` Pierre Muller
2009-05-28 16:23 ` Paul Pluzhnikov
2009-05-28 16:37 ` Tom Tromey
2009-05-28 16:31 ` Paul Pluzhnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3bppdtf9p.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=muller@ics.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox