From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-64044-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25751 invoked by alias); 28 May 2009 15:38:54 -0000
Received: (qmail 25742 invoked by uid 22791); 28 May 2009 15:38:52 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 May 2009 15:38:46 +0000
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) 	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4SFcfwF003495; 	Thu, 28 May 2009 11:38:41 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n4SFceQ7012554; 	Thu, 28 May 2009 11:38:40 -0400
Received: from opsy.redhat.com (vpn-12-61.rdu.redhat.com [10.11.12.61]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n4SFcdHK022982; 	Thu, 28 May 2009 11:38:39 -0400
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 5F87A508281; Thu, 28 May 2009 09:32:03 -0600 (MDT)
To: "Pierre Muller" <muller@ics.u-strasbg.fr>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [RFA] Build failure fix: Python troubles on non-python targets...
References: <001001c9df7b$8f2a3810$ad7ea830$@u-strasbg.fr>
From: Tom Tromey <tromey@redhat.com>
Reply-To: tromey@redhat.com
Date: Thu, 28 May 2009 15:38:00 -0000
In-Reply-To: <001001c9df7b$8f2a3810$ad7ea830$@u-strasbg.fr> (Pierre Muller's message of "Thu\, 28 May 2009 12\:03\:33 +0200")
Message-ID: <m3bppdtf9p.fsf@fleche.redhat.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-05/txt/msg00607.txt.bz2

>>>>> "Pierre" == Pierre Muller <muller@ics.u-strasbg.fr> writes:

Pierre> On DJGPP,
Pierre> I now get this failure:
[...]

Sorry about that.

Pierre> The following two changes fixes compilation for me:
Pierre> Is this patch OK?

Nearly...

Pierre> +
Pierre> +#ifdef HAVE_PYTHON
Pierre> +
Pierre>  #include "python.h"
Pierre>  #include "python-internal.h"
 
This should unconditionally include python.h.  So, the conditional
needs to be moved down a few lines.  It is ok to include python.h even
if Python is not available; and in this case it is desirable so that
the declarations are picked up (and thus checked against the
definitions).

Ok with that change.  Thanks.

Tom