Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Sami Wagiaalla <swagiaal@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Add namespace aliasing support.
Date: Tue, 02 Feb 2010 19:23:00 -0000	[thread overview]
Message-ID: <m3bpg71lyc.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4B673929.9040900@redhat.com> (Sami Wagiaalla's message of "Mon, 	01 Feb 2010 15:27:21 -0500")

>>>>> "Sami" == Sami Wagiaalla <swagiaal@redhat.com> writes:

Sami> 2010-02-01  Sami Wagiaalla  <swagiaal@redhat.com>
Sami>    * cp-support.h: Added char* alias element to using_direct data
Sami>    struct.

I noticed that an earlier ChangeLog entry of yours (in testsuite) had 4
leading spaces rather than a tab.  This one seems to have the same
problem, at least if you cut-and-pasted it; please fix before
committing.

Also, put the PR number into the ChangeLog entry and the commit.  You
can see the existing ChangeLog for some examples of the formatting.
Putting it in the ChangeLog just makes the entry a little more useful;
putting it into the commit message will make some info about the commit
be automatically appended to the PR.

Sami> +   scope.  If ALIAS is an empty string then the namespace is known by its
Sami> +   original name.

This should say something like:  If ALIAS is not null, then ...

Sami> +   of the list.  ALIAS is set to a non empty string if the imported namespace
Sami> +   has been aliased.

Likewise.

This patch is ok with those things fixed.  Thanks.

Tom


  reply	other threads:[~2010-02-02 19:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-29 16:27 Sami Wagiaalla
2010-01-29 20:23 ` Tom Tromey
2010-02-01 20:25   ` Sami Wagiaalla
2010-02-02 19:23     ` Tom Tromey [this message]
2010-02-09  0:38       ` Doug Evans
2010-02-09  1:38         ` Tom Tromey
2010-02-09 17:03           ` Sami Wagiaalla
2010-02-09 19:37         ` Sami Wagiaalla
2010-02-09 19:56           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3bpg71lyc.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=swagiaal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox