From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13163 invoked by alias); 2 Feb 2010 19:23:16 -0000 Received: (qmail 13155 invoked by uid 22791); 2 Feb 2010 19:23:15 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 02 Feb 2010 19:23:10 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o12JN9ee026629 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 2 Feb 2010 14:23:09 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o12JN8ZE023021; Tue, 2 Feb 2010 14:23:09 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o12JN7VQ019190; Tue, 2 Feb 2010 14:23:08 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 6608937998B; Tue, 2 Feb 2010 12:23:07 -0700 (MST) From: Tom Tromey To: Sami Wagiaalla Cc: gdb-patches@sourceware.org Subject: Re: [patch] Add namespace aliasing support. References: <4B630D3F.8010507@redhat.com> <4B673929.9040900@redhat.com> Reply-To: tromey@redhat.com Date: Tue, 02 Feb 2010 19:23:00 -0000 In-Reply-To: <4B673929.9040900@redhat.com> (Sami Wagiaalla's message of "Mon, 01 Feb 2010 15:27:21 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00045.txt.bz2 >>>>> "Sami" == Sami Wagiaalla writes: Sami> 2010-02-01 Sami Wagiaalla Sami> * cp-support.h: Added char* alias element to using_direct data Sami> struct. I noticed that an earlier ChangeLog entry of yours (in testsuite) had 4 leading spaces rather than a tab. This one seems to have the same problem, at least if you cut-and-pasted it; please fix before committing. Also, put the PR number into the ChangeLog entry and the commit. You can see the existing ChangeLog for some examples of the formatting. Putting it in the ChangeLog just makes the entry a little more useful; putting it into the commit message will make some info about the commit be automatically appended to the PR. Sami> + scope. If ALIAS is an empty string then the namespace is known by its Sami> + original name. This should say something like: If ALIAS is not null, then ... Sami> + of the list. ALIAS is set to a non empty string if the imported namespace Sami> + has been aliased. Likewise. This patch is ok with those things fixed. Thanks. Tom