From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix implicit pointer offsets
Date: Mon, 25 Jul 2011 16:05:00 -0000 [thread overview]
Message-ID: <m3bowitmvu.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20110724211142.GA2913@host1.jankratochvil.net> (Jan Kratochvil's message of "Sun, 24 Jul 2011 23:11:42 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> 2011-07-24 Jan Kratochvil <jan.kratochvil@redhat.com>
Jan> Fix implicit pointer offsets.
Jan> * dwarf2loc.c (indirect_pieced_value): Comment byte_offset. Use also
Jan> ptr.OFFSET.
Jan> gdb/testsuite/
Jan> 2011-07-24 Jan Kratochvil <jan.kratochvil@redhat.com>
Jan> Fix implicit pointer offsets.
Jan> * gdb.dwarf2/implptr.c (add): New marker baz breakpoint.
Jan> * gdb.dwarf2/implptr.exp ( set baz breakpoint for implptr)
Jan> (continue to breakpoint: continue to baz breakpoint for implptr)
Jan> (sanity check element 0, sanity check element 1)
Jan> (enter the inlined function, check element 0 for the offset)
Jan> (check element 1 for the offset)
Jan> (continue to breakpoint: ignore the second baz breakpoint): New tests.
Jan> (set foo breakpoint for implptr): Update the breakpoint number.
Thanks Jan. This looks good to me.
Tom
next prev parent reply other threads:[~2011-07-25 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 7:19 Jan Kratochvil
2011-07-25 16:05 ` Tom Tromey [this message]
2011-07-25 16:30 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3bowitmvu.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox