From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12115 invoked by alias); 25 Jul 2011 15:12:57 -0000 Received: (qmail 12107 invoked by uid 22791); 25 Jul 2011 15:12:57 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 25 Jul 2011 15:12:40 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6PFCdih006945 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 25 Jul 2011 11:12:39 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p6PFCdq0013471; Mon, 25 Jul 2011 11:12:39 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p6PFCcTU000723; Mon, 25 Jul 2011 11:12:38 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix implicit pointer offsets References: <20110724211142.GA2913@host1.jankratochvil.net> Date: Mon, 25 Jul 2011 16:05:00 -0000 In-Reply-To: <20110724211142.GA2913@host1.jankratochvil.net> (Jan Kratochvil's message of "Sun, 24 Jul 2011 23:11:42 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00694.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> 2011-07-24 Jan Kratochvil Jan> Fix implicit pointer offsets. Jan> * dwarf2loc.c (indirect_pieced_value): Comment byte_offset. Use also Jan> ptr.OFFSET. Jan> gdb/testsuite/ Jan> 2011-07-24 Jan Kratochvil Jan> Fix implicit pointer offsets. Jan> * gdb.dwarf2/implptr.c (add): New marker baz breakpoint. Jan> * gdb.dwarf2/implptr.exp ( set baz breakpoint for implptr) Jan> (continue to breakpoint: continue to baz breakpoint for implptr) Jan> (sanity check element 0, sanity check element 1) Jan> (enter the inlined function, check element 0 for the offset) Jan> (check element 1 for the offset) Jan> (continue to breakpoint: ignore the second baz breakpoint): New tests. Jan> (set foo breakpoint for implptr): Update the breakpoint number. Thanks Jan. This looks good to me. Tom