From: Phil Muldoon <pmuldoon@redhat.com>
To: Paul Koning <paulkoning@comcast.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [Python] Patch to fix memory leak
Date: Wed, 07 Sep 2011 09:33:00 -0000 [thread overview]
Message-ID: <m3bouw3doj.fsf@redhat.com> (raw)
In-Reply-To: <9E006B29-53D6-475E-9024-E1E9933A99C6@comcast.net> (Paul Koning's message of "Tue, 6 Sep 2011 14:01:02 -0400")
Paul Koning <paulkoning@comcast.net> writes:
> PyList_Append increments the reference count of the item being
> appended to the list, and two of the places in the GDB Python code
> that use it don't take that into account. The result is a memory
> leak. The attached patch fixes that.
For some reason the Python API manual is silent about PyList_Append
incrementing the reference count. But I did check, and you are correct,
the reference count is incremented when added to a list.
> Tested by using a debug build of Python with reference counting
> enabled, and turning on dumping of final leftover objects.
This is fine, thanks for doing this. I cannot give you check-in
permission as I am not a maintainer. Please wait until one of the
maintainers signs-off before you go ahead.
Cheers,
Phil
next prev parent reply other threads:[~2011-09-07 9:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 19:36 Paul Koning
2011-09-07 9:33 ` Phil Muldoon [this message]
2011-09-07 10:35 ` Jan Kratochvil
2011-09-07 12:29 ` Paul Koning
2011-09-08 12:29 ` Sergio Durigan Junior
2011-09-15 18:08 ` PING: " Paul Koning
2011-09-15 18:34 ` Jan Kratochvil
2011-09-15 20:39 ` Paul Koning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3bouw3doj.fsf@redhat.com \
--to=pmuldoon@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=paulkoning@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox