From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26705 invoked by alias); 7 Sep 2011 09:27:43 -0000 Received: (qmail 26692 invoked by uid 22791); 7 Sep 2011 09:27:41 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Sep 2011 09:27:26 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p879RPvY017754 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 7 Sep 2011 05:27:25 -0400 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p879ROEi024472; Wed, 7 Sep 2011 05:27:24 -0400 From: Phil Muldoon To: Paul Koning Cc: gdb-patches@sourceware.org Subject: Re: [Python] Patch to fix memory leak References: <9E006B29-53D6-475E-9024-E1E9933A99C6@comcast.net> Reply-to: pmuldoon@redhat.com X-URL: http://www.redhat.com Date: Wed, 07 Sep 2011 09:33:00 -0000 In-Reply-To: <9E006B29-53D6-475E-9024-E1E9933A99C6@comcast.net> (Paul Koning's message of "Tue, 6 Sep 2011 14:01:02 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00105.txt.bz2 Paul Koning writes: > PyList_Append increments the reference count of the item being > appended to the list, and two of the places in the GDB Python code > that use it don't take that into account. The result is a memory > leak. The attached patch fixes that. For some reason the Python API manual is silent about PyList_Append incrementing the reference count. But I did check, and you are correct, the reference count is incremented when added to a list. > Tested by using a debug build of Python with reference counting > enabled, and turning on dumping of final leftover objects. This is fine, thanks for doing this. I cannot give you check-in permission as I am not a maintainer. Please wait until one of the maintainers signs-off before you go ahead. Cheers, Phil