From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [patch#2] Fix initial language with -readnow, regressed by: RFC: add DWARF index support
Date: Mon, 03 Oct 2011 19:56:00 -0000 [thread overview]
Message-ID: <m3botxsvdi.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20110929151423.GA1124@host1.jankratochvil.net> (Jan Kratochvil's message of "Thu, 29 Sep 2011 17:14:23 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> So I fixed rather the method implementation than to workaround it
Jan> in the caller.
Thanks.
This looks good.
Jan> BTW find_main_filename is the only caller of ->find_symbol_file.
The main-finding code has caused issues for various laziness patches
I've worked on. It would be nice to replace it.
Also I tripped across the call to set_main_name in dwarf2read.c ... it
seems bad for debuginfo reading to set global state. (Instead it could,
say, set a field on the objfile...)
Tom
next prev parent reply other threads:[~2011-10-03 19:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 23:08 [patch] " Jan Kratochvil
2011-09-28 23:12 ` Joel Brobecker
2011-09-28 23:20 ` Jan Kratochvil
2011-09-29 15:33 ` [patch#2] " Jan Kratochvil
2011-10-03 19:56 ` Tom Tromey [this message]
2011-10-09 18:38 ` Jan Kratochvil
2011-10-03 19:49 ` [patch] " Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3botxsvdi.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox