From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21359 invoked by alias); 3 Oct 2011 19:56:03 -0000 Received: (qmail 21347 invoked by uid 22791); 3 Oct 2011 19:56:02 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 03 Oct 2011 19:55:45 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p93JtNDA012833 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 3 Oct 2011 15:55:24 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p93JtNKK029700; Mon, 3 Oct 2011 15:55:23 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p93JtLhe022735; Mon, 3 Oct 2011 15:55:22 -0400 From: Tom Tromey To: Jan Kratochvil Cc: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [patch#2] Fix initial language with -readnow, regressed by: RFC: add DWARF index support References: <20110928220344.GA17977@host1.jankratochvil.net> <20110928230742.GB19246@adacore.com> <20110929151423.GA1124@host1.jankratochvil.net> Date: Mon, 03 Oct 2011 19:56:00 -0000 In-Reply-To: <20110929151423.GA1124@host1.jankratochvil.net> (Jan Kratochvil's message of "Thu, 29 Sep 2011 17:14:23 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00044.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> So I fixed rather the method implementation than to workaround it Jan> in the caller. Thanks. This looks good. Jan> BTW find_main_filename is the only caller of ->find_symbol_file. The main-finding code has caused issues for various laziness patches I've worked on. It would be nice to replace it. Also I tripped across the call to set_main_name in dwarf2read.c ... it seems bad for debuginfo reading to set global state. (Instead it could, say, set a field on the objfile...) Tom