From: Tom Tromey <tromey@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gdb-patches\@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA] c++/13225
Date: Fri, 14 Oct 2011 19:35:00 -0000 [thread overview]
Message-ID: <m3botje589.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4E970C86.80101@redhat.com> (Keith Seitz's message of "Thu, 13 Oct 2011 09:06:30 -0700")
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> Here is a new version which does this and adds several new tests. A
Keith> lot of the patch is massaging the rank_one_type/rank_function API to
Keith> accept an array of struct values (vs struct types).
Keith> Is this more what you had in mind?
Yes, thanks.
2 tiny nits.
Keith> +/* Baddness of converting integer 0 to NULL pointer. */
Typo, "badness".
Keith> +extern struct rank rank_one_type (struct type *, struct type *, struct value *);
This line is too long.
Ok with these fixed.
Tom
next prev parent reply other threads:[~2011-10-14 19:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 19:16 Keith Seitz
2011-10-11 19:36 ` Tom Tromey
2011-10-11 19:44 ` Keith Seitz
2011-10-12 13:40 ` Tom Tromey
2011-10-13 16:07 ` Keith Seitz
2011-10-14 19:35 ` Tom Tromey [this message]
2011-10-14 20:26 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3botje589.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox