From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9541 invoked by alias); 14 Oct 2011 19:35:57 -0000 Received: (qmail 9415 invoked by uid 22791); 14 Oct 2011 19:35:56 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 14 Oct 2011 19:35:36 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9EJZZul010026 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 14 Oct 2011 15:35:36 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p9EJZZmH001852; Fri, 14 Oct 2011 15:35:35 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p9EJZYqk027648; Fri, 14 Oct 2011 15:35:34 -0400 From: Tom Tromey To: Keith Seitz Cc: "gdb-patches\@sourceware.org ml" Subject: Re: [RFA] c++/13225 References: <4E9495DB.8010109@redhat.com> <4E949C94.4000004@redhat.com> <4E970C86.80101@redhat.com> Date: Fri, 14 Oct 2011 19:35:00 -0000 In-Reply-To: <4E970C86.80101@redhat.com> (Keith Seitz's message of "Thu, 13 Oct 2011 09:06:30 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00418.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> Here is a new version which does this and adds several new tests. A Keith> lot of the patch is massaging the rank_one_type/rank_function API to Keith> accept an array of struct values (vs struct types). Keith> Is this more what you had in mind? Yes, thanks. 2 tiny nits. Keith> +/* Baddness of converting integer 0 to NULL pointer. */ Typo, "badness". Keith> +extern struct rank rank_one_type (struct type *, struct type *, struct value *); This line is too long. Ok with these fixed. Tom