From: Tom Tromey <tromey@redhat.com>
To: dje@google.com (Doug Evans)
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 2/2] Make names in gdbtypes.h,symtab.h const char *.
Date: Mon, 06 Feb 2012 19:07:00 -0000 [thread overview]
Message-ID: <m3bopbpz5c.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20120202225218.BB5DD1E25BF@ruffy2.mtv.corp.google.com> (Doug Evans's message of "Thu, 2 Feb 2012 14:52:18 -0800 (PST)")
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> The changes to these two files involve a teensy bit of extra
Doug> work beyond simple mechanical changes.
Doug> This patch requires the main patch in
Doug> http://sourceware.org/ml/gdb-patches/2012-02/msg00043.html
FWIW this seems fine to me.
Doug> @@ -1455,10 +1455,11 @@ patch_type (struct type *type, struct ty
Doug> if (TYPE_NAME (real_target))
Doug> {
Doug> + /* The previous copy of TYPE_NAME is allocated by
Doug> + process_coff_symbol. */
Doug> if (TYPE_NAME (target))
Doug> - xfree (TYPE_NAME (target));
Doug> - TYPE_NAME (target) = concat (TYPE_NAME (real_target),
Doug> - (char *) NULL);
Doug> + xfree ((char*) TYPE_NAME (target));
Doug> + TYPE_NAME (target) = xstrdup (TYPE_NAME (real_target));
Doug> }
Doug> }
The old code here is pretty bad :(
Tom
prev parent reply other threads:[~2012-02-06 19:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 22:52 Doug Evans
2012-02-06 17:09 ` Doug Evans
2012-02-06 19:07 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3bopbpz5c.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox