From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14976 invoked by alias); 6 Feb 2012 19:07:56 -0000 Received: (qmail 14967 invoked by uid 22791); 6 Feb 2012 19:07:56 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Feb 2012 19:07:42 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q16J7dt0010267 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 6 Feb 2012 14:07:41 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q16IwPdI011516; Mon, 6 Feb 2012 13:58:25 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id q16IwN3l002847; Mon, 6 Feb 2012 13:58:24 -0500 From: Tom Tromey To: dje@google.com (Doug Evans) Cc: gdb-patches@sourceware.org Subject: Re: [RFA 2/2] Make names in gdbtypes.h,symtab.h const char *. References: <20120202225218.BB5DD1E25BF@ruffy2.mtv.corp.google.com> Date: Mon, 06 Feb 2012 19:07:00 -0000 In-Reply-To: <20120202225218.BB5DD1E25BF@ruffy2.mtv.corp.google.com> (Doug Evans's message of "Thu, 2 Feb 2012 14:52:18 -0800 (PST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00060.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> The changes to these two files involve a teensy bit of extra Doug> work beyond simple mechanical changes. Doug> This patch requires the main patch in Doug> http://sourceware.org/ml/gdb-patches/2012-02/msg00043.html FWIW this seems fine to me. Doug> @@ -1455,10 +1455,11 @@ patch_type (struct type *type, struct ty Doug> if (TYPE_NAME (real_target)) Doug> { Doug> + /* The previous copy of TYPE_NAME is allocated by Doug> + process_coff_symbol. */ Doug> if (TYPE_NAME (target)) Doug> - xfree (TYPE_NAME (target)); Doug> - TYPE_NAME (target) = concat (TYPE_NAME (real_target), Doug> - (char *) NULL); Doug> + xfree ((char*) TYPE_NAME (target)); Doug> + TYPE_NAME (target) = xstrdup (TYPE_NAME (real_target)); Doug> } Doug> } The old code here is pretty bad :( Tom