Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Gabriel Krisman Bertazi <gabriel@krisman.be>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix gdb.fortran/array-element.exp failures.
Date: Sun, 06 Jul 2014 19:03:00 -0000	[thread overview]
Message-ID: <m3bnt28g3s.fsf@redhat.com> (raw)
In-Reply-To: <8761jbbu6l.fsf@Argo.krisman.be> (Gabriel Krisman Bertazi's	message of "Sat, 05 Jul 2014 14:18:42 -0300")

On Saturday, July 05 2014, Gabriel Krisman Bertazi wrote:

> Sorry, I missed it. Here follows the patch and the updated changelog.
>
> 2014-07-05  Gabriel Krisman Bertazi  <gabriel@krisman.be>
>
> 	* array-element.exp: Remove wrong "continue" command that caused
> 	test to fail and simplifies test case.

It should be:

	* gdb.fortran/array-element.exp

Also, and sorry for the nitpicking, but we write ChangeLog entries in
the imperative mode, so I'd write it as:

	* gdb.fortran/array-element.exp: Remove wrong "continue"
	  command.  Simplify test case.

Anyway, just minor comments, no need to resubmit the patch.  Let's wait
for some maintainer to take a look.

Thanks,

-- 
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


  reply	other threads:[~2014-07-06 19:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-04  5:58 Gabriel Krisman Bertazi
2014-07-04 15:35 ` Sergio Durigan Junior
2014-07-04 23:20   ` Gabriel Krisman Bertazi
2014-07-05 12:14     ` Sergio Durigan Junior
2014-07-05 17:17       ` Gabriel Krisman Bertazi
2014-07-06 19:03         ` Sergio Durigan Junior [this message]
2014-07-14 23:28           ` Gabriel Krisman Bertazi
2014-08-17  4:07             ` Gabriel Krisman Bertazi
2014-08-26  0:30               ` [PING] " Gabriel Krisman Bertazi
2014-09-04 19:31                 ` Gabriel Krisman Bertazi
2014-09-09 13:09                 ` Joel Brobecker
2014-09-09 14:55                   ` Gabriel Krisman Bertazi
2014-09-09 15:45                     ` Joel Brobecker
2014-09-09 18:17                       ` Gabriel Krisman Bertazi
2014-09-10 12:50                         ` Joel Brobecker
2014-09-10 16:11                           ` Sergio Durigan Junior
2014-09-11  3:25                           ` Gabriel Krisman Bertazi
2014-09-09 15:08                   ` Sergio Durigan Junior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3bnt28g3s.fsf@redhat.com \
    --to=sergiodj@redhat.com \
    --cc=gabriel@krisman.be \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox