From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26287 invoked by alias); 6 Jul 2014 19:03:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26268 invoked by uid 89); 6 Jul 2014 19:03:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 06 Jul 2014 19:03:30 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s66J3N23004682 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 6 Jul 2014 15:03:23 -0400 Received: from psique (ovpn-113-28.phx2.redhat.com [10.3.113.28]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s66J3KTL023787 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 6 Jul 2014 15:03:22 -0400 From: Sergio Durigan Junior To: Gabriel Krisman Bertazi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix gdb.fortran/array-element.exp failures. References: <1404453487-20108-1-git-send-email-gabriel@krisman.be> <87zjgobth0.fsf@Argo.krisman.be> <8761jbbu6l.fsf@Argo.krisman.be> X-URL: http://www.redhat.com Date: Sun, 06 Jul 2014 19:03:00 -0000 In-Reply-To: <8761jbbu6l.fsf@Argo.krisman.be> (Gabriel Krisman Bertazi's message of "Sat, 05 Jul 2014 14:18:42 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00103.txt.bz2 On Saturday, July 05 2014, Gabriel Krisman Bertazi wrote: > Sorry, I missed it. Here follows the patch and the updated changelog. > > 2014-07-05 Gabriel Krisman Bertazi > > * array-element.exp: Remove wrong "continue" command that caused > test to fail and simplifies test case. It should be: * gdb.fortran/array-element.exp Also, and sorry for the nitpicking, but we write ChangeLog entries in the imperative mode, so I'd write it as: * gdb.fortran/array-element.exp: Remove wrong "continue" command. Simplify test case. Anyway, just minor comments, no need to resubmit the patch. Let's wait for some maintainer to take a look. Thanks, -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/