From: Andreas Arnez <arnez@linux.ibm.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Don't print symbol definition's line number in rbreak output
Date: Tue, 17 Apr 2018 17:33:00 -0000 [thread overview]
Message-ID: <m3bmeh4u1f.fsf@oc1027705133.ibm.com> (raw)
In-Reply-To: <60d22f70-9f4f-00e2-cfba-cd8d9acecd42@redhat.com> (Pedro Alves's message of "Tue, 17 Apr 2018 17:56:53 +0100")
On Tue, Apr 17 2018, Pedro Alves wrote:
> On 04/17/2018 05:38 PM, Andreas Arnez wrote:
>
>>> The patch looks fine to me. However, I notice now that this doesn't
>>> tweak any existing testcase or add any new one. Was the problem
>>> caught by some existing testcase?
>>
>> Yes, it was. The attached v2 now provides this information and should
>> also address all your previous comments.
>
> Ah, cool.
>
>>
>> OK to push?
>
> OK. Thanks for the patience.
NP, thanks for your comments. I've pushed this now.
--
Andreas
prev parent reply other threads:[~2018-04-17 17:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 18:44 Andreas Arnez
2018-04-16 19:01 ` Pedro Alves
2018-04-17 12:28 ` Andreas Arnez
2018-04-17 15:18 ` Pedro Alves
2018-04-17 16:39 ` Andreas Arnez
2018-04-17 16:56 ` Pedro Alves
2018-04-17 17:33 ` Andreas Arnez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3bmeh4u1f.fsf@oc1027705133.ibm.com \
--to=arnez@linux.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox