From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37303 invoked by alias); 17 Apr 2018 17:33:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37293 invoked by uid 89); 17 Apr 2018 17:33:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Apr 2018 17:33:41 +0000 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3HHVriS105101 for ; Tue, 17 Apr 2018 13:33:40 -0400 Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111]) by mx0a-001b2d01.pphosted.com with ESMTP id 2hdjrh8yhy-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Tue, 17 Apr 2018 13:33:39 -0400 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 17 Apr 2018 18:33:36 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp15.uk.ibm.com (192.168.101.145) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 17 Apr 2018 18:33:34 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w3HHXYCT9175342; Tue, 17 Apr 2018 17:33:34 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0CFA8AE051; Tue, 17 Apr 2018 18:23:24 +0100 (BST) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E0EA8AE055; Tue, 17 Apr 2018 18:23:23 +0100 (BST) Received: from oc1027705133.ibm.com (unknown [9.152.212.201]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 17 Apr 2018 18:23:23 +0100 (BST) From: Andreas Arnez To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Don't print symbol definition's line number in rbreak output References: <4eae39d3-c6ca-ef5b-4127-0ad29ee792c9@redhat.com> <60d22f70-9f4f-00e2-cfba-cd8d9acecd42@redhat.com> Date: Tue, 17 Apr 2018 17:33:00 -0000 In-Reply-To: <60d22f70-9f4f-00e2-cfba-cd8d9acecd42@redhat.com> (Pedro Alves's message of "Tue, 17 Apr 2018 17:56:53 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 18041717-0020-0000-0000-00000412FAC2 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18041717-0021-0000-0000-000042A73C0C Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-17_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804170152 X-SW-Source: 2018-04/txt/msg00346.txt.bz2 On Tue, Apr 17 2018, Pedro Alves wrote: > On 04/17/2018 05:38 PM, Andreas Arnez wrote: > >>> The patch looks fine to me. However, I notice now that this doesn't >>> tweak any existing testcase or add any new one. Was the problem >>> caught by some existing testcase? >> >> Yes, it was. The attached v2 now provides this information and should >> also address all your previous comments. > > Ah, cool. > >> >> OK to push? > > OK. Thanks for the patience. NP, thanks for your comments. I've pushed this now. -- Andreas