Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: Andreas Schwab <schwab@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch] Speed up dwarf2_frame_find_fde
Date: Thu, 06 Aug 2009 21:24:00 -0000	[thread overview]
Message-ID: <m3ab2cfxun.fsf@fleche.redhat.com> (raw)
In-Reply-To: <8ac60eac0908041208g477503e9n8079bd8df935b8b1@mail.gmail.com> (Paul Pluzhnikov's message of "Tue\, 4 Aug 2009 12\:08\:18 -0700")

>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:

Tom> I don't understand this comment.

Paul> Before the patch:
Paul> -  /* First add the information from the .eh_frame section.  That way,
Paul> -     the FDEs from that section are searched last.  */
Paul> IOW, we prefer .debug_frame entries to .eh_frame ones.

Paul> After the patch, .eh_frame entries are sorted after .debug_frame
Paul> ones in the fde_table, and are then duplicate-eliminated when the
Paul> final fde_table is constructed here:

Thanks for the explanation.  I didn't make this connection.

This patch is ok.

Tom


      reply	other threads:[~2009-08-06 21:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-22  5:37 Paul Pluzhnikov
2009-07-22 10:02 ` Andreas Schwab
2009-07-22 23:12   ` Paul Pluzhnikov
2009-07-30  3:13     ` Paul Pluzhnikov
2009-08-04 18:18     ` Tom Tromey
2009-08-04 19:08       ` Paul Pluzhnikov
2009-08-06 21:24         ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ab2cfxun.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ppluzhnikov@google.com \
    --cc=schwab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox