From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20074 invoked by alias); 6 Aug 2009 21:15:29 -0000 Received: (qmail 20043 invoked by uid 22791); 6 Aug 2009 21:15:27 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 Aug 2009 21:15:18 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n76LFFDZ006565; Thu, 6 Aug 2009 17:15:15 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n76LFER5017574; Thu, 6 Aug 2009 17:15:14 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n76LFCHN004908; Thu, 6 Aug 2009 17:15:13 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id BCE8737858F; Thu, 6 Aug 2009 15:15:12 -0600 (MDT) To: Paul Pluzhnikov Cc: Andreas Schwab , gdb-patches@sourceware.org Subject: Re: [patch] Speed up dwarf2_frame_find_fde References: <20090721223129.85D1F76BC0@localhost> <8ac60eac0907221324n28e246c1k5e62f79973955ae@mail.gmail.com> <8ac60eac0908041208g477503e9n8079bd8df935b8b1@mail.gmail.com> From: Tom Tromey Reply-To: Tom Tromey Date: Thu, 06 Aug 2009 21:24:00 -0000 In-Reply-To: <8ac60eac0908041208g477503e9n8079bd8df935b8b1@mail.gmail.com> (Paul Pluzhnikov's message of "Tue\, 4 Aug 2009 12\:08\:18 -0700") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00095.txt.bz2 >>>>> "Paul" == Paul Pluzhnikov writes: Tom> I don't understand this comment. Paul> Before the patch: Paul> - /* First add the information from the .eh_frame section. That way, Paul> - the FDEs from that section are searched last. */ Paul> IOW, we prefer .debug_frame entries to .eh_frame ones. Paul> After the patch, .eh_frame entries are sorted after .debug_frame Paul> ones in the fde_table, and are then duplicate-eliminated when the Paul> final fde_table is constructed here: Thanks for the explanation. I didn't make this connection. This patch is ok. Tom