Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
Cc: gdb-patches@sourceware.org, Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH] Gracefully handle not being able to access a DWARF 	register number
Date: Fri, 30 Apr 2010 18:08:00 -0000	[thread overview]
Message-ID: <m3aaskzucj.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1272365614.19466.6.camel@e102111-lin.cambridge.arm.com> (Matthew	Gretton-Dann's message of "Tue, 27 Apr 2010 11:53:34 +0100")

>>>>> "Matthew" == Matthew Gretton-Dann <matthew.gretton-dann@arm.com> writes:

Matthew> 2010-04-27  Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>
Matthew>         * dwarf2loc.c (read_pieced_value, write_pieced_value,
Matthew>         dwarf2_evaluate_loc_desc): Handle not being able to access DWARF
Matthew>         registers gracefully.

This is ok.  Thanks.

It seems that some targets already emit a warning in their
dwarf2_reg_to_regnum implementation.  E.g., amd64-tdep.c:

  if (regnum == -1)
    warning (_("Unmapped DWARF Register #%d encountered."), reg);

This is inconsistently done, though, and IMO doesn't impact the
usefulness of your patch.

Tom


      reply	other threads:[~2010-04-30 18:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-26 15:28 Matthew Gretton-Dann
2010-04-26 20:06 ` Tom Tromey
2010-04-26 20:21   ` Sergio Durigan Junior
2010-04-27 10:54   ` Matthew Gretton-Dann
2010-04-30 18:08     ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3aaskzucj.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=matthew.gretton-dann@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox