From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19890 invoked by alias); 30 Apr 2010 18:08:55 -0000 Received: (qmail 19879 invoked by uid 22791); 30 Apr 2010 18:08:53 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Apr 2010 18:08:49 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3UI8Xm2006836 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 30 Apr 2010 14:08:33 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3UI8UKM032299; Fri, 30 Apr 2010 14:08:30 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o3UI8TW2024754; Fri, 30 Apr 2010 14:08:29 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id D37433795F9; Fri, 30 Apr 2010 12:08:28 -0600 (MDT) From: Tom Tromey To: Matthew Gretton-Dann Cc: gdb-patches@sourceware.org, Richard Earnshaw Subject: Re: [PATCH] Gracefully handle not being able to access a DWARF register number References: <1272295674.16160.23.camel@e102111-lin.cambridge.arm.com> <1272365614.19466.6.camel@e102111-lin.cambridge.arm.com> Reply-To: tromey@redhat.com Date: Fri, 30 Apr 2010 18:08:00 -0000 In-Reply-To: <1272365614.19466.6.camel@e102111-lin.cambridge.arm.com> (Matthew Gretton-Dann's message of "Tue, 27 Apr 2010 11:53:34 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg01007.txt.bz2 >>>>> "Matthew" == Matthew Gretton-Dann writes: Matthew> 2010-04-27 Matthew Gretton-Dann Matthew> * dwarf2loc.c (read_pieced_value, write_pieced_value, Matthew> dwarf2_evaluate_loc_desc): Handle not being able to access DWARF Matthew> registers gracefully. This is ok. Thanks. It seems that some targets already emit a warning in their dwarf2_reg_to_regnum implementation. E.g., amd64-tdep.c: if (regnum == -1) warning (_("Unmapped DWARF Register #%d encountered."), reg); This is inconsistently done, though, and IMO doesn't impact the usefulness of your patch. Tom