From: Tom Tromey <tromey@redhat.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] eval, valops, valarith, valprint, printcmd.c: delete unused variables.
Date: Fri, 07 May 2010 17:23:00 -0000 [thread overview]
Message-ID: <m3aasbhbhf.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4BE30B48.9040800@vmware.com> (Michael Snyder's message of "Thu, 06 May 2010 11:32:40 -0700")
>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
Michael> struct value *
Michael> value_cast_pointers (struct type *type, struct value *arg2)
Michael> {
Michael> - struct type *type1 = check_typedef (type);
Michael> struct type *type2 = check_typedef (value_type (arg2));
Michael> struct type *t1 = check_typedef (TYPE_TARGET_TYPE (type));
Michael> struct type *t2 = check_typedef (TYPE_TARGET_TYPE (type2));
In this case I think the intent is for t1 to reference type1, and not type.
I would recommend making that change rather than deleting type1.
Tom
next prev parent reply other threads:[~2010-05-07 17:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 18:32 Michael Snyder
2010-05-07 17:23 ` Tom Tromey [this message]
2010-05-07 18:49 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3aasbhbhf.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox