From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72894-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7111 invoked by alias); 7 May 2010 17:23:50 -0000
Received: (qmail 7100 invoked by uid 22791); 7 May 2010 17:23:49 -0000
X-SWARE-Spam-Status: No, hits=-5.7 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 May 2010 17:23:45 +0000
Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o47HNhHZ025794	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 7 May 2010 13:23:43 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o47HNgw3016313;	Fri, 7 May 2010 13:23:42 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o47HNfQu015212;	Fri, 7 May 2010 13:23:41 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id 288AB378183; Fri,  7 May 2010 11:23:41 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] eval, valops, valarith, valprint, printcmd.c: delete unused variables.
References: <4BE30B48.9040800@vmware.com>
Reply-To: tromey@redhat.com
Date: Fri, 07 May 2010 17:23:00 -0000
In-Reply-To: <4BE30B48.9040800@vmware.com> (Michael Snyder's message of "Thu,	06 May 2010 11:32:40 -0700")
Message-ID: <m3aasbhbhf.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-05/txt/msg00187.txt.bz2

>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:

Michael>  struct value *
Michael>  value_cast_pointers (struct type *type, struct value *arg2)
Michael>  {
Michael> -  struct type *type1 = check_typedef (type);
Michael>    struct type *type2 = check_typedef (value_type (arg2));
Michael>    struct type *t1 = check_typedef (TYPE_TARGET_TYPE (type));
Michael>    struct type *t2 = check_typedef (TYPE_TARGET_TYPE (type2));

In this case I think the intent is for t1 to reference type1, and not type.
I would recommend making that change rather than deleting type1.

Tom