From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Doug Evans <dje@google.com>, Eli Zaretskii <eliz@gnu.org>,
gdb-patches@sourceware.org,
David Malcolm <dmalcolm@redhat.com>
Subject: Re: [patch] Fix python gdb.execute to not paginate
Date: Mon, 09 Aug 2010 17:30:00 -0000 [thread overview]
Message-ID: <m3aaovk81z.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100807150149.GA20523@host1.dyn.jankratochvil.net> (Jan Kratochvil's message of "Sat, 7 Aug 2010 17:01:49 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> +2010-08-07 Jan Kratochvil <jan.kratochvil@redhat.com>
Jan> +
Jan> + * defs.h (make_cleanup_restore_uinteger, make_cleanup_restore_ui_file)
Jan> + (make_cleanup_restore_page_info)
Jan> + (set_batch_flag_and_make_cleanup_restore_page_info): New declarations.
Jan> + * gdbcmd.h (execute_command_to_string): New declaration.
Jan> + * python/python.c (struct restore_ui_file_closure, restore_ui_file)
Jan> + (make_cleanup_restore_ui_file): Move to utils.c
Jan> + (execute_gdb_command) <to_string>: Move ...
Jan> + * top.c (execute_command_to_string): ... here. Call
Jan> + set_batch_flag_and_make_cleanup_restore_page_info.
Jan> + * utils.c (make_cleanup_restore_integer): New source file blank line.
Jan> + (make_cleanup_restore_uinteger): New.
Jan> + (struct restore_ui_file_closure, do_restore_ui_file)
Jan> + (make_cleanup_restore_ui_file): Move here from python/python.c.
Jan> + (init_page_info) <batch_flag>
Jan> + (do_restore_page_info_cleanup, make_cleanup_restore_page_info)
Jan> + (set_batch_flag_and_make_cleanup_restore_page_info): New.
I think this should go on the 7.2 branch as well.
It fixes a pretty serious bug in a feature that is new to 7.2.
Tom
next prev parent reply other threads:[~2010-08-09 17:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-05 21:20 Jan Kratochvil
2010-08-06 0:49 ` Doug Evans
2010-08-06 1:22 ` Doug Evans
2010-08-06 17:15 ` Tom Tromey
2010-08-06 17:27 ` Doug Evans
2010-08-06 10:29 ` Jan Kratochvil
2010-08-06 21:37 ` Doug Evans
2010-08-07 15:02 ` Jan Kratochvil
2010-08-09 17:30 ` Tom Tromey [this message]
2010-08-09 19:24 ` Jan Kratochvil
2010-08-06 8:35 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3aaovk81z.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dje@google.com \
--cc=dmalcolm@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox