From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25349 invoked by alias); 9 Aug 2010 17:30:47 -0000 Received: (qmail 25339 invoked by uid 22791); 9 Aug 2010 17:30:46 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Aug 2010 17:30:39 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o79HUXY3015257 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 9 Aug 2010 13:30:33 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o79HUXhb015031; Mon, 9 Aug 2010 13:30:33 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o79HUWnG028966; Mon, 9 Aug 2010 13:30:32 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 43D0A3781A0; Mon, 9 Aug 2010 11:30:32 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: Doug Evans , Eli Zaretskii , gdb-patches@sourceware.org, David Malcolm Subject: Re: [patch] Fix python gdb.execute to not paginate References: <83k4o4w34e.fsf@gnu.org> <20100806102912.GA20604@host1.dyn.jankratochvil.net> <20100807150149.GA20523@host1.dyn.jankratochvil.net> Date: Mon, 09 Aug 2010 17:30:00 -0000 In-Reply-To: <20100807150149.GA20523@host1.dyn.jankratochvil.net> (Jan Kratochvil's message of "Sat, 7 Aug 2010 17:01:49 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00104.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> +2010-08-07 Jan Kratochvil Jan> + Jan> + * defs.h (make_cleanup_restore_uinteger, make_cleanup_restore_ui_file) Jan> + (make_cleanup_restore_page_info) Jan> + (set_batch_flag_and_make_cleanup_restore_page_info): New declarations. Jan> + * gdbcmd.h (execute_command_to_string): New declaration. Jan> + * python/python.c (struct restore_ui_file_closure, restore_ui_file) Jan> + (make_cleanup_restore_ui_file): Move to utils.c Jan> + (execute_gdb_command) : Move ... Jan> + * top.c (execute_command_to_string): ... here. Call Jan> + set_batch_flag_and_make_cleanup_restore_page_info. Jan> + * utils.c (make_cleanup_restore_integer): New source file blank line. Jan> + (make_cleanup_restore_uinteger): New. Jan> + (struct restore_ui_file_closure, do_restore_ui_file) Jan> + (make_cleanup_restore_ui_file): Move here from python/python.c. Jan> + (init_page_info) Jan> + (do_restore_page_info_cleanup, make_cleanup_restore_page_info) Jan> + (set_batch_flag_and_make_cleanup_restore_page_info): New. I think this should go on the 7.2 branch as well. It fixes a pretty serious bug in a feature that is new to 7.2. Tom