From: Tom Tromey <tromey@redhat.com>
To: pmuldoon@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] [python] python/12686
Date: Wed, 20 Apr 2011 19:32:00 -0000 [thread overview]
Message-ID: <m3aafk1zxn.fsf@fleche.redhat.com> (raw)
In-Reply-To: <m3fwpdav6y.fsf@redhat.com> (Phil Muldoon's message of "Wed, 20 Apr 2011 14:50:13 +0100")
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> Kevin Pouget noticed that when GDB called the Python 'stop' callback,
Phil> the terminal stilled belonged to the inferior. GDB intercepts the
Phil> signal generated from terminal input and it forces GDB into the
Phil> background. While this patch is simple, I would like feedback. I
Phil> believe the terminal is restored to the inferior when the inferior is
Phil> resumed (local tests seem to show this), but I am not totally sure. Is
Phil> acquiring the terminal the right thing to do here? I was trying to think
Phil> of a scenario where the Python method would need the inferior terminal,
Phil> but could not.
Phil> Comments?
I don't think we want to do this here.
I'm not really sure of the implications, but it isn't something that
most implementations of the `stop' method are going to want.
If we really need to, we can provide some explicit functions to
manipulate this state from Python. TBH I think asking the user
questions here is weird.
Tom
next prev parent reply other threads:[~2011-04-20 19:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 13:50 Phil Muldoon
2011-04-20 19:32 ` Tom Tromey [this message]
2011-04-20 20:10 ` Kevin Pouget
2011-04-25 19:29 ` Tom Tromey
2011-04-28 13:40 ` Kevin Pouget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3aafk1zxn.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox