From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14904 invoked by alias); 20 Apr 2011 19:32:57 -0000 Received: (qmail 14895 invoked by uid 22791); 20 Apr 2011 19:32:57 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Apr 2011 19:32:38 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3KJWb2l006466 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 20 Apr 2011 15:32:37 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p3KJWbBA031375; Wed, 20 Apr 2011 15:32:37 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p3KJWaVM024864; Wed, 20 Apr 2011 15:32:36 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 317D037808F; Wed, 20 Apr 2011 13:32:36 -0600 (MDT) From: Tom Tromey To: pmuldoon@redhat.com Cc: gdb-patches@sourceware.org Subject: Re: [patch] [python] python/12686 References: Date: Wed, 20 Apr 2011 19:32:00 -0000 In-Reply-To: (Phil Muldoon's message of "Wed, 20 Apr 2011 14:50:13 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00373.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> Kevin Pouget noticed that when GDB called the Python 'stop' callback, Phil> the terminal stilled belonged to the inferior. GDB intercepts the Phil> signal generated from terminal input and it forces GDB into the Phil> background. While this patch is simple, I would like feedback. I Phil> believe the terminal is restored to the inferior when the inferior is Phil> resumed (local tests seem to show this), but I am not totally sure. Is Phil> acquiring the terminal the right thing to do here? I was trying to think Phil> of a scenario where the Python method would need the inferior terminal, Phil> but could not. Phil> Comments? I don't think we want to do this here. I'm not really sure of the implications, but it isn't something that most implementations of the `stop' method are going to want. If we really need to, we can provide some explicit functions to manipulate this state from Python. TBH I think asking the user questions here is weird. Tom