From: Tom Tromey <tromey@redhat.com>
To: Kevin Pouget <kevin.pouget@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Handle multiple breakpoint hits in Python interface
Date: Wed, 31 Aug 2011 17:49:00 -0000 [thread overview]
Message-ID: <m3aaap79pt.fsf@fleche.redhat.com> (raw)
In-Reply-To: <BANLkTikPMgQ9fwKBcv7zuWHm7mf=hAP86w@mail.gmail.com> (Kevin Pouget's message of "Mon, 30 May 2011 06:52:39 -0400")
>>>>> "Kevin" == Kevin Pouget <kevin.pouget@gmail.com> writes:
Kevin> 2011-04-30 Kevin Pouget <kevin.pouget@st.com>
Kevin> Handle multiple breakpoint hits in Python interface:
Kevin> * gdb.texinfo (Events In Python): New function documentation:
Kevin> gdb.BreakpointEvent.breakpoints. Indicate that
Kevin> gdb.BreakpointEvent.breakpoint is now deprecated.
[...]
Kevin> + if (PyList_Append (list, (PyObject *) current_bs->breakpoint_at->py_bp_object))
I suggest introducing a PyObject* variable whose value is the second
argument here. Then you don't need to reformat this line or the
subsequent assignment to first_bp:
Kevin> + first_bp = (PyObject *) current_bs->breakpoint_at->py_bp_object;
Kevin> + Py_XDECREF(list);
Missing space before "(".
Otherwise seems reasonable.
Could you please write NEWS patches for your change to the Python API?
Tom
next prev parent reply other threads:[~2011-08-31 17:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BANLkTik-ffBpfx4BALF5+Y0xSx_NnaCs7g@mail.gmail.com>
2011-04-22 9:34 ` Kevin Pouget
2011-05-19 18:34 ` Tom Tromey
2011-05-23 9:39 ` Kevin Pouget
2011-05-23 10:51 ` Eli Zaretskii
2011-05-23 11:01 ` Kevin Pouget
2011-05-23 11:59 ` Eli Zaretskii
2011-05-27 20:09 ` Tom Tromey
2011-05-30 7:37 ` Kevin Pouget
2011-05-30 7:49 ` Eli Zaretskii
2011-05-30 10:53 ` Kevin Pouget
2011-08-31 17:49 ` Tom Tromey [this message]
2011-09-01 8:36 ` Kevin Pouget
2011-09-01 8:52 ` Kevin Pouget
2011-09-01 10:08 ` Pedro Alves
2011-09-01 10:18 ` Eli Zaretskii
2011-09-01 11:41 ` Kevin Pouget
2011-09-01 15:39 ` Pedro Alves
2011-09-01 20:53 ` Eli Zaretskii
2011-09-15 12:34 ` Kevin Pouget
2011-09-16 7:55 ` [commit] gdb.python/py-evthreads.exp regression [Re: [PATCH] Handle multiple breakpoint hits in Python interface] Jan Kratochvil
2011-09-16 9:12 ` Kevin Pouget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3aaap79pt.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=kevin.pouget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox