From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-83408-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2417 invoked by alias); 31 Aug 2011 17:49:21 -0000
Received: (qmail 2405 invoked by uid 22791); 31 Aug 2011 17:49:20 -0000
X-SWARE-Spam-Status: No, hits=-7.2 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 31 Aug 2011 17:49:06 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7VHn41d004202	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 31 Aug 2011 13:49:04 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p7VHn3P7009315;	Wed, 31 Aug 2011 13:49:04 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p7VHn2PV020401;	Wed, 31 Aug 2011 13:49:02 -0400
From: Tom Tromey <tromey@redhat.com>
To: Kevin Pouget <kevin.pouget@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Handle multiple breakpoint hits in Python interface
References: <BANLkTik-ffBpfx4BALF5+Y0xSx_NnaCs7g@mail.gmail.com>	<BANLkTinWAR40Fp5TsPubiucTOKygJHHZsw@mail.gmail.com>	<m3d3jea6ak.fsf@fleche.redhat.com>	<BANLkTik0q4iqSUH9B9ue=0uHzbJqjv32yA@mail.gmail.com>	<m3zkm7ucrb.fsf@fleche.redhat.com>	<BANLkTi=TJNb57D_UkmPW-ZGfYVaRqGE5=w@mail.gmail.com>	<E1QQxDK-0007FP-T4@fencepost.gnu.org>	<BANLkTikPMgQ9fwKBcv7zuWHm7mf=hAP86w@mail.gmail.com>
Date: Wed, 31 Aug 2011 17:49:00 -0000
In-Reply-To: <BANLkTikPMgQ9fwKBcv7zuWHm7mf=hAP86w@mail.gmail.com> (Kevin	Pouget's message of "Mon, 30 May 2011 06:52:39 -0400")
Message-ID: <m3aaap79pt.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-08/txt/msg00668.txt.bz2

>>>>> "Kevin" == Kevin Pouget <kevin.pouget@gmail.com> writes:

Kevin> 2011-04-30  Kevin Pouget  <kevin.pouget@st.com>
Kevin> 	Handle multiple breakpoint hits in Python interface:
Kevin> 	* gdb.texinfo (Events In Python): New function documentation:
Kevin> 	gdb.BreakpointEvent.breakpoints. Indicate that
Kevin> 	gdb.BreakpointEvent.breakpoint is now deprecated.
[...]

Kevin> +          if (PyList_Append (list, (PyObject *) current_bs->breakpoint_at->py_bp_object)) 

I suggest introducing a PyObject* variable whose value is the second
argument here.  Then you don't need to reformat this line or the
subsequent assignment to first_bp:

Kevin> +            first_bp = (PyObject *) current_bs->breakpoint_at->py_bp_object;

Kevin> +  Py_XDECREF(list);

Missing space before "(".

Otherwise seems reasonable.

Could you please write NEWS patches for your change to the Python API?

Tom