From: Sergio Durigan Junior <sergiodj@redhat.com>
To: nick clifton <nickc@redhat.com>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org,
Pedro Alves <palves@redhat.com>
Subject: Re: [RFC/PATCH] Fix `bfd_{get,set}_*' macros
Date: Wed, 16 May 2012 19:48:00 -0000 [thread overview]
Message-ID: <m3aa176h6x.fsf@redhat.com> (raw)
In-Reply-To: <4FB3D727.9070605@redhat.com> (nick clifton's message of "Wed, 16 May 2012 17:34:47 +0100")
On Wednesday, May 16 2012, nick clifton wrote:
> Hi Sergio,
>
>> 2012-05-04 Sergio Durigan Junior<sergiodj@redhat.com>
>>
>> * bfd-in2.h (bfd_get_section_name, bfd_get_section_vma,
>> bfd_get_section_lma, bfd_get_section_alignment,
>> bfd_get_section_flags,
>> bfd_get_section_userdata): Rewrite macros in order to use the
>> `bfd' argument.
>> * elf-vxworks.c (elf_vxworks_finish_dynamic_entry): Pass proper `bfd'
>> as the first argument for `bfd_get_section_alignment'.
>> * elf32-arm.c (create_ifunc_sections): Likewise, for
>> `bfd_set_section_alignment'.
>> * elf32-m32r.c (m32r_elf_relocate_section): Likewise, for
>> `bfd_get_section_name'.
>> * elf32-microblaze.c (microblaze_elf_relocate_section): Likewise.
>> * elf32-ppc.c (ppc_elf_size_dynamic_sections): Likewise.
>> (ppc_elf_relocate_section): Likewise.
>> * elf64-mmix.c (mmix_final_link_relocate): Likewise, for
>> `bfd_get_section_vma'.
>> * elf64-ppc.c (create_linkage_sections): Likewise, for
>> `bfd_set_section_alignment'.
>
> I have applied this patch. There were however a few problems with it:
Hello Nick,
Thanks a lot for pointing out the errors. I really did not test using
--enable-targets=all (somehow I thought this flag was specific to
GDB!). Anyway, this won't happen again.
Thanks a lot,
--
Sergio
next prev parent reply other threads:[~2012-05-16 19:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 4:19 Sergio Durigan Junior
2012-05-03 7:54 ` Alan Modra
2012-05-03 16:01 ` Pedro Alves
2012-05-03 16:22 ` Sergio Durigan Junior
2012-05-04 21:46 ` Sergio Durigan Junior
2012-05-10 1:54 ` Sergio Durigan Junior
2012-05-16 18:28 ` nick clifton
2012-05-16 19:48 ` Sergio Durigan Junior [this message]
2012-05-03 13:17 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3aa176h6x.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=nickc@redhat.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox