From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15789 invoked by alias); 16 May 2012 19:48:45 -0000 Received: (qmail 15648 invoked by uid 22791); 16 May 2012 19:48:44 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 May 2012 19:48:16 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4GJmEAh029666 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 16 May 2012 15:48:15 -0400 Received: from psique ([10.3.112.2]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q4GJm7nP013520; Wed, 16 May 2012 15:48:10 -0400 From: Sergio Durigan Junior To: nick clifton Cc: binutils@sourceware.org, gdb-patches@sourceware.org, Pedro Alves Subject: Re: [RFC/PATCH] Fix `bfd_{get,set}_*' macros References: <20120503075305.GJ635@bubble.grove.modra.org> <4FB3D727.9070605@redhat.com> X-URL: http://www.redhat.com Date: Wed, 16 May 2012 19:48:00 -0000 In-Reply-To: <4FB3D727.9070605@redhat.com> (nick clifton's message of "Wed, 16 May 2012 17:34:47 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00621.txt.bz2 On Wednesday, May 16 2012, nick clifton wrote: > Hi Sergio, > >> 2012-05-04 Sergio Durigan Junior >> >> * bfd-in2.h (bfd_get_section_name, bfd_get_section_vma, >> bfd_get_section_lma, bfd_get_section_alignment, >> bfd_get_section_flags, >> bfd_get_section_userdata): Rewrite macros in order to use the >> `bfd' argument. >> * elf-vxworks.c (elf_vxworks_finish_dynamic_entry): Pass proper `bfd' >> as the first argument for `bfd_get_section_alignment'. >> * elf32-arm.c (create_ifunc_sections): Likewise, for >> `bfd_set_section_alignment'. >> * elf32-m32r.c (m32r_elf_relocate_section): Likewise, for >> `bfd_get_section_name'. >> * elf32-microblaze.c (microblaze_elf_relocate_section): Likewise. >> * elf32-ppc.c (ppc_elf_size_dynamic_sections): Likewise. >> (ppc_elf_relocate_section): Likewise. >> * elf64-mmix.c (mmix_final_link_relocate): Likewise, for >> `bfd_get_section_vma'. >> * elf64-ppc.c (create_linkage_sections): Likewise, for >> `bfd_set_section_alignment'. > > I have applied this patch. There were however a few problems with it: Hello Nick, Thanks a lot for pointing out the errors. I really did not test using --enable-targets=all (somehow I thought this flag was specific to GDB!). Anyway, this won't happen again. Thanks a lot, -- Sergio