From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Aleksandar Ristovski <aristovski@qnx.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] cleanup: Wunused corefile.c
Date: Sun, 03 Feb 2013 00:05:00 -0000 [thread overview]
Message-ID: <m3a9rmtg70.fsf@redhat.com> (raw)
In-Reply-To: <510C3998.5050309@qnx.com> (Aleksandar Ristovski's message of "Fri, 1 Feb 2013 16:54:32 -0500")
On Friday, February 01 2013, Aleksandar Ristovski wrote:
> Index: gdb/corefile.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/corefile.c,v
> retrieving revision 1.71
> diff -u -p -r1.71 corefile.c
> --- gdb/corefile.c 14 Jan 2013 21:03:54 -0000 1.71
> +++ gdb/corefile.c 1 Feb 2013 21:48:42 -0000
> @@ -149,7 +149,11 @@ reopen_exec_file (void)
> cleanups = make_cleanup (xfree, filename);
> res = stat (filename, &st);
>
> - if (exec_bfd_mtime && exec_bfd_mtime != st.st_mtime)
> + if (res != 0 && info_verbose)
> + warning (_("File %s could not be stat-ed (%s)\n"), filename,
> + strerror (errno));
Thanks for that. GDB uses `safe_strerror' instead of `strerror'.
--
Sergio
prev parent reply other threads:[~2013-02-03 0:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 19:36 Aleksandar Ristovski
2013-01-31 20:24 ` Tom Tromey
2013-01-31 20:29 ` Aleksandar Ristovski
2013-02-01 21:16 ` Tom Tromey
2013-02-01 21:31 ` Aleksandar Ristovski
2013-02-01 21:54 ` Aleksandar Ristovski
2013-02-03 0:05 ` Sergio Durigan Junior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3a9rmtg70.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=aristovski@qnx.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox