From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26261 invoked by alias); 3 Feb 2013 00:05:41 -0000 Received: (qmail 26229 invoked by uid 22791); 3 Feb 2013 00:05:38 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 03 Feb 2013 00:05:29 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1305Q2V022754 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 2 Feb 2013 19:05:27 -0500 Received: from psique (ovpn-113-130.phx2.redhat.com [10.3.113.130]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r1305NWY031385; Sat, 2 Feb 2013 19:05:25 -0500 From: Sergio Durigan Junior To: Aleksandar Ristovski Cc: "gdb-patches\@sourceware.org" Subject: Re: [patch] cleanup: Wunused corefile.c References: <510AC74E.1010709@qnx.com> <87vcad5cf1.fsf@fleche.redhat.com> <510AD43E.3040405@qnx.com> <87boc34z0o.fsf@fleche.redhat.com> <510C3418.4040802@qnx.com> <510C3998.5050309@qnx.com> X-URL: http://www.redhat.com Date: Sun, 03 Feb 2013 00:05:00 -0000 In-Reply-To: <510C3998.5050309@qnx.com> (Aleksandar Ristovski's message of "Fri, 1 Feb 2013 16:54:32 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00048.txt.bz2 On Friday, February 01 2013, Aleksandar Ristovski wrote: > Index: gdb/corefile.c > =================================================================== > RCS file: /cvs/src/src/gdb/corefile.c,v > retrieving revision 1.71 > diff -u -p -r1.71 corefile.c > --- gdb/corefile.c 14 Jan 2013 21:03:54 -0000 1.71 > +++ gdb/corefile.c 1 Feb 2013 21:48:42 -0000 > @@ -149,7 +149,11 @@ reopen_exec_file (void) > cleanups = make_cleanup (xfree, filename); > res = stat (filename, &st); > > - if (exec_bfd_mtime && exec_bfd_mtime != st.st_mtime) > + if (res != 0 && info_verbose) > + warning (_("File %s could not be stat-ed (%s)\n"), filename, > + strerror (errno)); Thanks for that. GDB uses `safe_strerror' instead of `strerror'. -- Sergio