From: Tom Tromey <tromey@redhat.com>
To: Tristan Gingold <gingold@ACT-Europe.FR>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Always use addr info to add a separate debug file
Date: Wed, 06 Jan 2010 19:43:00 -0000 [thread overview]
Message-ID: <m38wcb3tqo.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100106111823.GA15402@chinon.act-europe.fr> (Tristan Gingold's message of "Wed, 6 Jan 2010 12:18:23 +0100")
>>>>> "Tristan" == Tristan Gingold <gingold@ACT-Europe.FR> writes:
Tristan> 2010-01-04 Tristan Gingold <gingold@adacore.com>
Tristan> * symfile.c (build_section_addr_info_from_objfile): New function.
Tristan> (symbol_file_add_separate): Don't use offsets from objfile but
Tristan> built an addr info.
Thanks. Just one nit.
Tristan> + sap->other[i].addr = bfd_get_section_vma (objfile->obfd, sec)
Tristan> + + objfile->section_offsets->offsets[i];
According to GNU rules the RHS of the assignment should be
parenthesized, and the second line thus more deeply indented.
Ok with that change.
Tom
next prev parent reply other threads:[~2010-01-06 19:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 11:18 Tristan Gingold
2010-01-06 19:43 ` Tom Tromey [this message]
2010-01-07 9:32 ` Tristan Gingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38wcb3tqo.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=gingold@ACT-Europe.FR \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox