From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15662 invoked by alias); 6 Jan 2010 19:43:25 -0000 Received: (qmail 15651 invoked by uid 22791); 6 Jan 2010 19:43:24 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Jan 2010 19:43:20 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o06JgghI029474 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 6 Jan 2010 14:42:42 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o06Jgfsk019560; Wed, 6 Jan 2010 14:42:41 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o06Jgek5023001; Wed, 6 Jan 2010 14:42:41 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 6B32A37817D; Wed, 6 Jan 2010 12:42:40 -0700 (MST) From: Tom Tromey To: Tristan Gingold Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Always use addr info to add a separate debug file References: <20100106111823.GA15402@chinon.act-europe.fr> Reply-To: tromey@redhat.com Date: Wed, 06 Jan 2010 19:43:00 -0000 In-Reply-To: <20100106111823.GA15402@chinon.act-europe.fr> (Tristan Gingold's message of "Wed, 6 Jan 2010 12:18:23 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00121.txt.bz2 >>>>> "Tristan" == Tristan Gingold writes: Tristan> 2010-01-04 Tristan Gingold Tristan> * symfile.c (build_section_addr_info_from_objfile): New function. Tristan> (symbol_file_add_separate): Don't use offsets from objfile but Tristan> built an addr info. Thanks. Just one nit. Tristan> + sap->other[i].addr = bfd_get_section_vma (objfile->obfd, sec) Tristan> + + objfile->section_offsets->offsets[i]; According to GNU rules the RHS of the assignment should be parenthesized, and the second line thus more deeply indented. Ok with that change. Tom