Re: [RFC] Detect loops in the solib chain

[Tom Tromey <tromey@redhat.com>]

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> 2010-04-09  Daniel Jacobowitz  <dan@codesourcery.com>
Jan> 	    Paul Pluzhnikov  <ppluzhnikov@google.com>
Jan> 	    Jan Kratochvil  <jan.kratochvil@redhat.com>
Jan> 	Fix deadlock on looped list of loaded shared objects.
Jan> 	* solib-svr4.c (LM_PREV): New function.
Jan> 	(IGNORE_FIRST_LINK_MAP_ENTRY): Use it.
Jan> 	(svr4_current_sos): Check for correct l_prev.  New variables prev_lm
Jan> 	and next_lm.  Clear prev_lm for solib_svr4_r_ldsomap.
Jan> 	* config/djgpp/fnchange.lst: Add translation for solib-corrupted.exp.

Kevin already ok'd this part.
(FWIW I agree it is ok.)

Jan> 2010-04-09  Jan Kratochvil  <jan.kratochvil@redhat.com>
Jan> 	Fix deadlock on looped list of loaded shared objects.
Jan> 	* gdb.base/solib-corrupted.exp: New.

Jan> +	# glibc debug info is not available and it is too difficult to find and
Jan> +	# parse it from this testcase without the gdb supporting functions.
Jan> +	xfail "$test (no _r_debug symbol)"
Jan> +	untested ${testfile}.exp
Jan> +	return
Jan> +    }
Jan> +    -re " = 0x\[0-9a-f\]+\r\n$gdb_prompt $" {
Jan> +	pass $test

I think it is preferable to have the test name the same, regardless of
whether it passes or xfails.  Extra info can be logged with verbose.

This is ok with that change.

thanks,
Tom