From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5420 invoked by alias); 23 Apr 2010 20:09:56 -0000 Received: (qmail 5408 invoked by uid 22791); 23 Apr 2010 20:09:54 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 23 Apr 2010 20:09:49 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3NK9jSe011495 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 23 Apr 2010 16:09:45 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3NK9iZR012794; Fri, 23 Apr 2010 16:09:44 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o3NK9ht1027437; Fri, 23 Apr 2010 16:09:44 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 5C9F437849C; Fri, 23 Apr 2010 14:09:43 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org, Paul Pluzhnikov , Kevin Buettner Subject: Re: [RFC] Detect loops in the solib chain References: <20080718160210.66b480e9@mesquite.lan> <20080717220959.GA10652@caradoc.them.org> <20100409154123.GA8218@host0.dyn.jankratochvil.net> <20100409210255.GA26135@host0.dyn.jankratochvil.net> Reply-To: tromey@redhat.com Date: Fri, 23 Apr 2010 20:09:00 -0000 In-Reply-To: <20100409210255.GA26135@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Fri, 9 Apr 2010 23:02:55 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00814.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> 2010-04-09 Daniel Jacobowitz Jan> Paul Pluzhnikov Jan> Jan Kratochvil Jan> Fix deadlock on looped list of loaded shared objects. Jan> * solib-svr4.c (LM_PREV): New function. Jan> (IGNORE_FIRST_LINK_MAP_ENTRY): Use it. Jan> (svr4_current_sos): Check for correct l_prev. New variables prev_lm Jan> and next_lm. Clear prev_lm for solib_svr4_r_ldsomap. Jan> * config/djgpp/fnchange.lst: Add translation for solib-corrupted.exp. Kevin already ok'd this part. (FWIW I agree it is ok.) Jan> 2010-04-09 Jan Kratochvil Jan> Fix deadlock on looped list of loaded shared objects. Jan> * gdb.base/solib-corrupted.exp: New. Jan> + # glibc debug info is not available and it is too difficult to find and Jan> + # parse it from this testcase without the gdb supporting functions. Jan> + xfail "$test (no _r_debug symbol)" Jan> + untested ${testfile}.exp Jan> + return Jan> + } Jan> + -re " = 0x\[0-9a-f\]+\r\n$gdb_prompt $" { Jan> + pass $test I think it is preferable to have the test name the same, regardless of whether it passes or xfails. Extra info can be logged with verbose. This is ok with that change. thanks, Tom