From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 1/7] Support a ring of related breakpoints
Date: Mon, 21 Mar 2011 20:11:00 -0000 [thread overview]
Message-ID: <m38vw8utku.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20110319211505.GB30867@host1.jankratochvil.net> (Jan Kratochvil's message of "Sat, 19 Mar 2011 22:15:06 +0100")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> currently breakpoint->related_breakpoint is used only to connect
Jan> two related breakpoints. During STT_GNU_IFUNC one thread can be in
Jan> the resolver while another thread also enters the resolver. But
Jan> both threads will have a different return address where GDB wants
Jan> to fetch the resolved address. Therefore one needs to track
Jan> arbitrary number of the return address breakpoints while still
Jan> catching new entries to the STT_GNU_IFUNC resolver.
I read this and it looks fine to me.
At first I didn't see how a ring was actually created, but the only set
of this field is in watch_command_1, and it links the two together:
b->related_breakpoint = scope_breakpoint;
scope_breakpoint->related_breakpoint = b;
Tom
next prev parent reply other threads:[~2011-03-21 20:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-19 21:15 Jan Kratochvil
2011-03-21 20:11 ` Tom Tromey [this message]
2011-03-21 20:38 ` Jan Kratochvil
2011-03-28 20:23 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38vw8utku.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox